chore: write build number to summary - no ticket #2232
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uild-number-to-github-step-summary-
caldrian
force-pushed
the
feat/add-build-number-to-github-step-summary-
branch
from
d733a5e
to
feb2a9d
Compare
netbe
reviewed
Dec 2, 2024
Comment on lines
+303
to
+306
| if summary_file.nil? || summary_file.empty? | ||
| UI.error("GITHUB_STEP_SUMMARY is not set. Are you running in GitHub Actions?") | ||
| return | ||
| end |
There was a problem hiding this comment.
does it stop fastlane locally? if yes, we should just warn instead
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit feb2a9d. |
netbe
reviewed
Dec 3, 2024
|
|
||
| File.open(summary_file, "a") do |file| | ||
| file.puts "## Fastlane Summary" | ||
| file.puts "- 🛠️ Version: '#{extra_info}'" |
There was a problem hiding this comment.
I wonder if we can list also here the framework list tested
KaterinaWire
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR adds some code to the Fastfile which prints the build number of the build to the step summary:
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: